Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAPPL-382/CAPPL-366] Miscellaneous fixes #15666

Merged
merged 1 commit into from
Dec 12, 2024
Merged

[CAPPL-382/CAPPL-366] Miscellaneous fixes #15666

merged 1 commit into from
Dec 12, 2024

Conversation

cedric-cordenier
Copy link
Contributor

  • Add name to the hashing function for generating a workflow ID.
  • Normalize the owner in the secrets payload before verifying it.

@cedric-cordenier cedric-cordenier marked this pull request as ready for review December 12, 2024 17:00
@cedric-cordenier cedric-cordenier requested review from a team as code owners December 12, 2024 17:00
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited
Loading

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Flakeguard Root Project / Get Tests To Run , Core Tests (go_core_tests) , lint , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Flakeguard Deployment Project / Get Tests To Run , Flakeguard Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/services/relay/evm/capabilities/workflow... , Flakeguard Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/services/workflows/syncer, ubuntu-latest) , Flakeguard Deployment Project / Run Tests , Flakeguard Deployment Project / Report , Flakey Test Detection , SonarQube Scan , Flakeguard Root Project / Report

1. Error parsing test results due to panic:

[A 1 <= 10 words sentence that describes the error]:[job id where the error happened]

Source of Error: 
Run tests with flakeguard	2024-12-12T17:58:44.8788037Z Error running tests: failed to parse test results: failed to attribute panic to test, using regex syncer\.(Test[^\.\(]+) on these strings:
Run tests with flakeguard	2024-12-12T17:58:44.8791163Z panic: Log in goroutine after Test_workflowRegisteredHandler/skips_fetch_if_config_url_is_missing has completed: 2024-12-12T17:57:05.941Z	DEBUG	CapabilitiesRegistry	capabilities/registry.go:69	get capability	{"version": "unset@unset", "id": "[email protected]"}
Run tests with flakeguard	2024-12-12T17:58:44.8792943Z 
Run tests with flakeguard	2024-12-12T17:58:44.8793146Z goroutine 356 [running]:
Run tests with flakeguard	2024-12-12T17:58:44.8793851Z testing.(*common).logDepth(0xc001092000, {0xc0000df2c0, 0x9b}, 0x3)
Run tests with flakeguard	2024-12-12T17:58:44.8795012Z 	/home/runner/go/pkg/mod/golang.org/[email protected]/src/testing/testing.go:1029 +0x6d4
Run tests with flakeguard	2024-12-12T17:58:44.8795895Z testing.(*common).log(...)
Run tests with flakeguard	2024-12-12T17:58:44.8796808Z 	/home/runner/go/pkg/mod/golang.org/[email protected]/src/testing/testing.go:1011
Run tests with flakeguard	2024-12-12T17:58:44.8797545Z testing.(*common).Logf(0xc001092000, {0x3c921d2, 0x2}, {0xc0013c4490, 0x1, 0x1})
Run tests with flakeguard	2024-12-12T17:58:44.8798254Z 	/home/runner/go/pkg/mod/golang.org/[email protected]/src/testing/testing.go:1062 +0xa5
Run tests with flakeguard	2024-12-12T17:58:44.8799459Z go.uber.org/zap/zaptest.TestingWriter.Write({{0x7f92dd5a0c50?, 0xc001092000?}, 0x80?}, {0xc001210400, 0x9c, 0x400})
Run tests with flakeguard	2024-12-12T17:58:44.8800167Z 	/home/runner/go/pkg/mod/go.uber.org/[email protected]/zaptest/logger.go:146 +0x11e
Run tests with flakeguard	2024-12-12T17:58:44.8801128Z go.uber.org/zap/zapcore.(*ioCore).Write(0xc000cc4db0, {0xff, {0xc1cee6dc7821da4a, 0x17867521d9, 0x592d0a0}, {0x3cb9ed8, 0x14}, {0x3cadad3, 0xe}, {0x1, ...}, ...}, ...)
Run tests with flakeguard	2024-12-12T17:58:44.8801934Z 	/home/runner/go/pkg/mod/go.uber.org/[email protected]/zapcore/core.go:99 +0x193
Run tests with flakeguard	2024-12-12T17:58:44.8802540Z go.uber.org/zap/zapcore.(*CheckedEntry).Write(0xc0013940d0, {0xc00179d180, 0x1, 0x2})
Run tests with flakeguard	2024-12-12T17:58:44.8803126Z 	/home/runner/go/pkg/mod/go.uber.org/[email protected]/zapcore/entry.go:253 +0x1f0
Run tests with flakeguard	2024-12-12T17:58:44.8803854Z go.uber.org/zap.(*SugaredLogger).log(0xc000ee6318, 0xff, {0x3cadad3, 0xe}, {0x0, 0x0, 0x0}, {0xc0013b8420, 0x2, 0x2})
Run tests with flakeguard	2024-12-12T17:58:44.8804492Z 	/home/runner/go/pkg/mod/go.uber.org/[email protected]/sugar.go:355 +0x130
Run tests with flakeguard	2024-12-12T17:58:44.8804929Z go.uber.org/zap.(*SugaredLogger).Debugw(...)
Run tests with flakeguard	2024-12-12T17:58:44.8805344Z 	/home/runner/go/pkg/mod/go.uber.org/[email protected]/sugar.go:251
Run tests with flakeguard	2024-12-12T17:58:44.8806163Z github.com/smartcontractkit/chainlink/v2/core/capabilities.(*Registry).Get(0xc0008ccd80, {0x7f93379823a8?, 0x20?}, {0xc001802030, 0x18})
Run tests with flakeguard	2024-12-12T17:58:44.8806957Z 	/home/runner/work/chainlink/chainlink/core/capabilities/registry.go:69 +0x1e2
Run tests with flakeguard	2024-12-12T17:58:44.8807887Z github.com/smartcontractkit/chainlink/v2/core/capabilities.(*Registry).GetTrigger(0xc0008ccd80, {0x4397cf0, 0xc000a2b270}, {0xc001802030, 0x18})
Run tests with flakeguard	2024-12-12T17:58:44.8808713Z 	/home/runner/work/chainlink/chainlink/core/capabilities/registry.go:80 +0x6f
Run tests with flakeguard	2024-12-12T17:58:44.8809665Z github.com/smartcontractkit/chainlink/v2/core/services/workflows.(*Engine).resolveWorkflowCapabilities(0xc0007ff208, {0x4397cf0, 0xc000a2b270})
Run tests with flakeguard	2024-12-12T17:58:44.8810546Z 	/home/runner/work/chainlink/chainlink/core/services/workflows/engine.go:172 +0x17e
Run tests with flakeguard	2024-12-12T17:58:44.8811243Z github.com/smartcontractkit/chainlink/v2/core/services/workflows.(*Engine).init.func1()
Run tests with flakeguard	2024-12-12T17:58:44.8812123Z 	/home/runner/work/chainlink/chainlink/core/services/workflows/engine.go:322 +0x2af
Run tests with flakeguard	2024-12-12T17:58:44.8813127Z github.com/smartcontractkit/chainlink/v2/core/services/workflows.retryable({0x4397cf0, 0xc000a2b270}, {0x43bac10, 0xc000e00f30}, 0x1388, 0x0, 0xc000a65ee0)
Run tests with flakeguard	2024-12-12T17:58:44.8814002Z 	/home/runner/work/chainlink/chainlink/core/services/workflows/retry.go:45 +0x402
Run tests with flakeguard	2024-12-12T17:58:44.8814849Z github.com/smartcontractkit/chainlink/v2/core/services/workflows.(*Engine).init(0xc0007ff208, {0x4397cf0, 0xc000a2b270})
Run tests with flakeguard	2024-12-12T17:58:44.8815631Z 	/home/runner/work/chainlink/chainlink/core/services/workflows/engine.go:313 +0x225
Run tests with flakeguard	2024-12-12T17:58:44.8816437Z created by github.com/smartcontractkit/chainlink/v2/core/services/workflows.(*Engine).Start.func1 in goroutine 241
Run tests with flakeguard	2024-12-12T17:58:44.8817197Z 	/home/runner/work/chainlink/chainlink/core/services/workflows/engine.go:153 +0x35a
Run tests with flakeguard	2024-12-12T17:58:44.8817875Z FAIL	github.com/smartcontractkit/chainlink/v2/core/services/workflows/syncer	101.094s
Run tests with flakeguard	2024-12-12T17:58:44.8818212Z 
Run tests with flakeguard	2024-12-12T17:58:44.8823002Z ##[error]Process completed with exit code 1.

Why: The error occurred because a log entry was made in a goroutine after the test Test_workflowRegisteredHandler/skips_fetch_if_config_url_is_missing had completed. This caused a panic that the test result parser could not attribute correctly.

Suggested fix: Ensure that all logging and other operations in goroutines are completed before the test ends. Use synchronization mechanisms like WaitGroup to ensure goroutines finish their tasks before the test completes.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

krehermann
krehermann previously approved these changes Dec 12, 2024
View reviewed changes
@cedric-cordenier cedric-cordenier added this pull request to the merge queue Dec 12, 2024
auto-merge was automatically disabled December 12, 2024 18:16

Pull Request is not mergeable

Merged via the queue into develop with commit acc3846 Dec 12, 2024
171 of 173 checks passed
@cedric-cordenier cedric-cordenier deleted the CAPPL-382-366-misc-fixes branch December 12, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ettec ettec ettec approved these changes

@krehermann krehermann krehermann approved these changes

@aareet aareet Awaiting requested review from aareet aareet is a code owner automatically assigned from smartcontractkit/foundations

@george-dorin george-dorin Awaiting requested review from george-dorin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cedric-cordenier @krehermann @ettec